compilehandlebars bug fixed #69

incandescentxxc · 2022-09-04T20:48:23Z

Fixed a bug in the compileHandleBars function, which prevents compiling assigned templates.
Added corresponding tests for Engine, to avoid such cases happening again.

…nt happening again

src/test/resources/render/sampleBase.html

src/test/java/org/icepear/echarts/render/engineTest.java

icepear-jzx

LGTM

incandescentxxc added 2 commits September 4, 2022 16:49

fix compilehandlebars variable bug & add corresponding tests to preve…

b085b83

…nt happening again

fix conflict

86be8c4

incandescentxxc force-pushed the snapshot-xxc branch from c0ab3aa to 86be8c4 Compare September 4, 2022 20:50

incandescentxxc requested a review from icepear-jzx September 4, 2022 20:51

close file reader

771c2e9

icepear-jzx reviewed Sep 4, 2022

View reviewed changes

src/test/resources/render/sampleBase.html Outdated Show resolved Hide resolved

icepear-jzx reviewed Sep 4, 2022

View reviewed changes

src/test/java/org/icepear/echarts/render/engineTest.java Outdated Show resolved Hide resolved

remove unit tests

7697cab

incandescentxxc requested a review from icepear-jzx September 4, 2022 21:30

icepear-jzx approved these changes Sep 4, 2022

View reviewed changes

icepear-jzx merged commit 4be2906 into master Sep 4, 2022

Provide feedback