Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compilehandlebars bug fixed #69

Merged
merged 4 commits into from Sep 4, 2022
Merged

compilehandlebars bug fixed #69

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b085b83
fix compilehandlebars variable bug & add corresponding tests to preve…
incandescentxxc Sep 4, 2022
86be8c4
fix conflict
incandescentxxc Sep 4, 2022
771c2e9
close file reader
incandescentxxc Sep 4, 2022
7697cab
remove unit tests
incandescentxxc Sep 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/icepear/echarts/render/Engine.java
View file
Open in desktop
Expand Up @@ -57,7 +57,7 @@ private String compileHandleBars(String templateName, Option option, String heig
ChartMeta chartMeta = new ChartMeta(height, width, jsonStr);
String html = "";
try {
Template template = handlebars.compile("index");
Template template = handlebars.compile(templateName);
html = template.apply(chartMeta);
} catch (IOException e) {
log.error(e.getMessage());
Expand Down