Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDDN: Some codexentry messages are invalid #1393

Closed
Athanasius opened this issue Jan 7, 2022 · 3 comments
Closed

EDDN: Some codexentry messages are invalid #1393

Athanasius opened this issue Jan 7, 2022 · 3 comments
Labels
bug EDDN unconfirmed An unconfirmed bug
Milestone

Comments

@Athanasius
Copy link
Contributor

The new EDDN logging has brought to light things like:

2022-01-07 14:45:20,076 - ERROR - Gateway:233: Failed Validation "[<ValidationError: "'' is too short">]" (729, "E:D Market Connector [Windows]", "5.2.4", "https://eddn.edcd.io/schemas/codexentry/1", "-")

Presumably we're allowing through some key where the value is an empty string, whereas the schema thinks there should always be a value of at least one character. This might mean relaxing the EDDN schema, or it might mean we need to do some checks and pre-processing.

@Athanasius
Copy link
Contributor Author

Checking the schema could be any of:

  1. System (name) - unlikely.
  2. Name - also unlikely I'd hope.
  3. Region - probably not?
  4. Category - please tell me Frontier set this on them all.
  5. SubCategory - perhaps not always applicable?
  6. Traits - but I'd hope it would just not populate the array if so.

Looking at my own examples of codexentry events all of them have everything but Traits, of which I have zero examples. For all I know it somtimes looks like:

Traits: [
 ''
]

or

Traits: [
  'foo',
  ''
]

@Athanasius
Copy link
Contributor Author

Athanasius commented Jan 7, 2022

It looks like this might be due to a game bug, sometimes writing '' as the System (name) value. CometBorne supplied a file of all their CodexEntry events, and in it I found over 8000 such instances, the latest being:

<removed>

That system is Pheia Aewsy LV-Y d11 (EDSM).

We probably want to start doing some validation of CodexEntry data in the EDDN plugin.

Ignore all of that. I goofed a jq filter, and set those fields to "", rather than testing if they already were.

@Athanasius
Copy link
Contributor Author

Closing in favour of #1431 , under the assumption this was some older messages being replayed that were recorded under an older, buggier version of EDMC and/or the game.

NB: We added codexentry schema support in 5.2.0 - 2021-10-25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug EDDN unconfirmed An unconfirmed bug
Projects
None yet
Development

No branches or pull requests

1 participant