Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to EDDB #2031

Closed
Rixxan opened this issue Jul 22, 2023 · 0 comments · Fixed by #2032
Closed

Remove references to EDDB #2031

Rixxan opened this issue Jul 22, 2023 · 0 comments · Fixed by #2032
Assignees
@Rixxan
Labels
code cleanup Cleaning up code dependencies Pull requests that update a dependency file enhancement

Comments

@Rixxan
Copy link
Contributor

Rixxan commented Jul 22, 2023

Describe the enhancement

Update dependencies and remove EDDB references. EDDB has been shut down, and thus there is no point in continuing to include EDDB files in EDMC.

Expected behavior

EDDB code should no longer be included in the project, and the default EDDB plugin should be removed.

Considered workarounds

Currently, the EDDB code sits in place and while it does not stop the program from functioning, it does add excess complexity which is not needed at this time.

Additional context

This will necessitate a Minor version change, and is not compatible with a simple patch change.
@Rixxan Rixxan added enhancement code cleanup Cleaning up code dependencies Pull requests that update a dependency file labels Jul 22, 2023
@Rixxan Rixxan self-assigned this Jul 22, 2023
Rixxan added a commit that referenced this issue Jul 22, 2023
@Rixxan
#2031 Update Dependencies
93a69ce
Rixxan added a commit that referenced this issue Jul 22, 2023
@Rixxan
#2031 Remove EDDB and Bump Version
86d4d89
@Rixxan Rixxan linked a pull request Jul 22, 2023 that will close this issue
#2031 Remove EDDB Code #2032
Merged
Rixxan added a commit that referenced this issue Jul 23, 2023
@Rixxan
#2031 Remove more references to EDDB
3563084
Rixxan added a commit that referenced this issue Jul 23, 2023
@Rixxan
#2031 Revert Potential Bad Change
779318d
Rixxan added a commit that referenced this issue Jul 23, 2023
@Rixxan
#2031 Remove Invalid Type Hint
bd822f7 
Also updates Observer type hints based on gorakhargosh/watchdog#982
C1701D added a commit that referenced this issue Jul 23, 2023
@C1701D
Merge pull request #2032 from EDCD/enhancement/2031/remove-eddb-code
5131f82 
#2031 Remove EDDB Code
# Added
- Imported temporary type hints per gorakhargosh/watchdog#982

# Changed
- A few defaults for URL settings
- Updated Dependencies to latest working versions
- Minor documentation updates

# Removed
- Removes EDDB Plugin and References
@Rixxan Rixxan closed this as completed Jul 23, 2023
@Rixxan Rixxan reopened this Jul 24, 2023
Rixxan added a commit that referenced this issue Jul 24, 2023
@Rixxan
#2031 Update Station URL Defaults
5258174
C1701D added a commit that referenced this issue Jul 26, 2023
@C1701D
Merge pull request #2035 from EDCD/fix/2031/5.9.0-rc2
6760a2f 
#2031 Update Station URL Defaults
@Rixxan Rixxan closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rixxan Rixxan

Labels
code cleanup Cleaning up code dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
1 participant
@Rixxan