Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stationType and carrierDockingAccess to EDDN Journal Send #2157

Open
Rixxan opened this issue Feb 9, 2024 · 0 comments
Open

Add stationType and carrierDockingAccess to EDDN Journal Send #2157

Rixxan opened this issue Feb 9, 2024 · 0 comments
Assignees
@Rixxan
Labels
EDDN enhancement Staged Feature Complete and in Testing for Next Release
Projects
Enhancement Tracker
Milestone
5.11

Comments

@Rixxan
Copy link
Contributor

Rixxan commented Feb 9, 2024

Describe the enhancement

Presently, EDDN does not get sent the station type or carrier docking access under any circumstances. This data is allowed by the endpoint, and is available under certain circumstances from the journal files (NOT the cAPI response)

While this isn't sent under all circumstances (#2156), we should at least send it when called.
@Rixxan Rixxan added this to the 5.10.x milestone Feb 9, 2024
@Rixxan Rixxan self-assigned this Feb 9, 2024
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Feb 9, 2024
@Rixxan
[EDCD#2157] Add Station and Docking Information When Available
4a4010a
@Rixxan Rixxan mentioned this issue Feb 9, 2024
Merged
C1701D added a commit that referenced this issue Feb 16, 2024
@C1701D
Merge pull request #2158 from HullSeals/enhancement/2157/send-station…
6efd618 
…-docking-data

[#2157] Add Station and Docking Data When Known
LGTM
@C1701D C1701D added the Staged Feature Complete and in Testing for Next Release label Feb 16, 2024
@Rixxan Rixxan modified the milestones: 5.10.x, 5.11.0 Mar 4, 2024
@Rixxan Rixxan added this to Pending in Enhancement Tracker via automation Mar 23, 2024
@Rixxan Rixxan moved this from Pending to Complete in Enhancement Tracker May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rixxan Rixxan

Labels
EDDN enhancement Staged Feature Complete and in Testing for Next Release
Projects
Enhancement Tracker
Complete
Milestone
5.11
Development

When branches are created from issues, their pull requests are automatically linked.

enhancement/2157/send-station-docking-data HullSeals/EDMarketConnector
2 participants
@Rixxan @C1701D