Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2186] Remove MacOS Support #2187

Merged
merged 23 commits into from Apr 6, 2024

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Mar 28, 2024

Description

Development of Elite Dangerous on macOS ended over half a decade ago. Recent changes to the macOS NSSound API may have resulted in EDMC no longer functioning. There is no functional manner to play Elite on macOS natively, and known macOS users have reported using Wine and the distributed EXEs to utilize EDMC and Elite.

This removes all references to macOS from the code ("Darwin") and simplifies/deprecates functions, translations, and other works as relevant. This also has the added benefit of significantly simplifying some aspects of code which will make future changes much easier.

This should not significantly impact the user experience on any other platform. This will require a documentation update on the Wiki.

Type of change

  • Enhancement
  • Bug fix by removal
  • UI Conversion of Some Elements

How has this been tested?

  • Tested on available development environments to ensure no/minimal changes to the UI are generated.

Resolves #2186

@Rixxan Rixxan added code cleanup Cleaning up code python Pull requests that update Python code OS Issue Ready for Review PRs ready for review and merge labels Mar 28, 2024
@Rixxan Rixxan added this to the 5.11.0 milestone Mar 28, 2024
@Rixxan Rixxan requested a review from C1701D March 28, 2024 14:43
@Rixxan Rixxan self-assigned this Mar 28, 2024
@Rixxan Rixxan added this to In Progress in General Code Cleanups Mar 28, 2024
@Rixxan Rixxan linked an issue Mar 28, 2024 that may be closed by this pull request
l10n.py Show resolved Hide resolved
monitor.py Show resolved Hide resolved
Copy link
Member

@C1701D C1701D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a handful of logic changes that need to be checked and a few other more minor comments, the rest looks good.

update.py Show resolved Hide resolved
EDMarketConnector.py Show resolved Hide resolved
EDMarketConnector.py Show resolved Hide resolved
myNotebook.py Outdated Show resolved Hide resolved
myNotebook.py Outdated Show resolved Hide resolved
myNotebook.py Outdated Show resolved Hide resolved
myNotebook.py Outdated Show resolved Hide resolved
myNotebook.py Outdated Show resolved Hide resolved
prefs.py Outdated Show resolved Hide resolved
protocol.py Outdated Show resolved Hide resolved
@Rixxan Rixxan requested a review from C1701D April 5, 2024 21:50
Copy link
Member

@C1701D C1701D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Padding is still broken, rest looks good.

protocol.py Outdated Show resolved Hide resolved
@Rixxan Rixxan merged commit 065e2ae into EDCD:develop Apr 6, 2024
1 check passed
@Rixxan Rixxan deleted the enhancement/2186/remove-darwin branch April 6, 2024 20:53
@Rixxan Rixxan moved this from In Progress to Done in General Code Cleanups Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Cleaning up code OS Issue python Pull requests that update Python code Ready for Review PRs ready for review and merge
Development

Successfully merging this pull request may close these issues.

Remove MacOS Support
2 participants