[2232] Fix Missing Preferences #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue that could present on clean installs where the EDSM keys weren't generated properly. When the heck did this bug get introduced???
Rixxan
added
bug
Plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue that could present on clean installs where the EDSM keys weren't generated properly. This will set the key if totally missing, else try and extend a mismatched API set with null values when able. This issue would most often present itself on clean installs.
Type of Change
Bug Fix
How Tested
Tested with mismatched, missing, and malformed EDSM preferences key entries, and ensuring the program recovers successfully from the reported replication steps.
Notes
Resolves #2232