Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity Name #24

Closed
cgries opened this issue Jun 6, 2019 · 1 comment
Closed

Entity Name #24

cgries opened this issue Jun 6, 2019 · 1 comment
Labels
bug
Projects
Priorities

Comments

@cgries
Copy link

cgries commented Jun 6, 2019

It appears that the content from data.table.description in make_eml is used to fill in the entity name. However, they are not the same and entity name should be specified separately.
@clnsmth clnsmth added the bug label Jan 6, 2020
@clnsmth clnsmth added this to To do in Priorities Jan 6, 2020
@clnsmth clnsmth moved this from To do to In progress in Priorities Jan 15, 2020
@clnsmth
Copy link
Contributor

clnsmth commented Jan 16, 2020

data.table.name and other.entity.name have been added as arguments to make_eml(). This fix defaults data.table.name to data.table and other.entity.name to other.entity with a warning message.

These changes (b54fff5) have been merged into the development branch.

@clnsmth clnsmth moved this from In progress to Done in Priorities Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Priorities
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgries @clnsmth