Skip to content

Commit

Permalink
Update docker commands to be docker-compose to handle unnamed con…
Browse files Browse the repository at this point in the history
…tainers for multi-version devstack support

https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902
Multiple devstack releases with one machine.

This is in regards to this pull request
https://github.com/edx/devstack/pull/532
Updating volumes for `themes` to work with the `ironwood` release.

Applying these changes to get local devstack working for ironwood release.

https://github.com/edx/devstack/pull/376
https://github.com/edx/devstack/pull/377
Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file.

Additional changes to get `devstack_docker` for Ironwood working multisite environment setup.

Additional changes needed to make `docker` commands work making use of the `dev.print-container.%` target to get the container id.

Reverting some of these commands back to `docker` type to align with what we did with edx@59f812e
  • Loading branch information
ztraboo authored and sambapete committed Jun 10, 2022
1 parent 03a5cb1 commit 9ca851b
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile.edx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ whitelabel-tests:
docker exec -t devstack.whitelabel env TEST_ENV=devstack TERM=$(TERM) bash /tmp/run_whitelabel_tests.sh

whitelabel-cleanup:
docker rm --force devstack.whitelabel
docker-compose rm --force devstack.whitelabel

whitelabel-shell: ## Start a whitelabel test shell session
docker exec -it devstack.whitelabel env TERM=$(TERM) bash
docker-compose exec -it devstack.whitelabel env TERM=$(TERM) bash
8 changes: 8 additions & 0 deletions docker-compose-watchers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ services:
BOK_CHOY_HOSTNAME: edx.devstack.lms_watcher
ASSET_WATCHER_TIMEOUT: 12
image: edxops/edxapp:${OPENEDX_RELEASE:-latest}
networks:
default:
aliases:
- edx.devstack.lms_watcher
volumes:
- ${DEVSTACK_WORKSPACE}/edx-platform:/edx/app/edxapp/edx-platform
- edxapp_lms_assets:/edx/var/edxapp/staticfiles/
Expand All @@ -26,6 +30,10 @@ services:
BOK_CHOY_HOSTNAME: edx.devstack.studio_watcher
ASSET_WATCHER_TIMEOUT: 12
image: edxops/edxapp:${OPENEDX_RELEASE:-latest}
networks:
default:
aliases:
- edx.devstack.studio_watcher
volumes:
- edxapp_studio_assets:/edx/var/edxapp/staticfiles/
- ${DEVSTACK_WORKSPACE}/edx-platform:/edx/app/edxapp/edx-platform
Expand Down
4 changes: 4 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,10 @@ services:
container_name: "edx.${COMPOSE_PROJECT_NAME:-devstack}.redis"
hostname: redis.devstack.edx
image: redis:2.8
networks:
default:
aliases:
- edx.devstack.redis
command: redis-server --requirepass password
networks:
default:
Expand Down
2 changes: 2 additions & 0 deletions upgrade_mongo_4_0.sh
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ echo -e "${GREEN}Restarting Mongo on version ${MONGO_VERSION}${NC}"
make dev.up.mongo
mongo_container="$(make --silent --no-print-directory dev.print-container.mongo)"

mongo_container="$(make -s dev.print-container.mongo)"

echo -e "${GREEN}Waiting for MongoDB...${NC}"
until docker exec "$mongo_container" mongo --eval 'db.serverStatus()' &> /dev/null
do
Expand Down

0 comments on commit 9ca851b

Please sign in to comment.