Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docker build #357

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

fix docker build #357

wants to merge 25 commits into from

Conversation

robkooper
Copy link
Contributor

  • push to dockerhub if setup
  • push to github
  • build arm (mac) container as well as x86

fixes #355

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Testing :

  • All new and existing tests passed.

@robkooper
fix docker build
0b4839c 
- push to dockerhub if setup
- push to github
- build arm (mac) container as well as x86
@robkooper
lowercase repo
658e617
@robkooper
more lowercase
504e593
@robkooper robkooper marked this pull request as draft October 16, 2022 15:50
@robkooper
Copy link
Contributor Author

working on adding the intel compiler

@robkooper robkooper marked this pull request as ready for review March 28, 2023 11:39
@robkooper
Copy link
Contributor Author

Please squash the PR when ready, to many build errors and tries.

@robkooper robkooper marked this pull request as draft May 26, 2023 16:35
@robkooper
Copy link
Contributor Author

Will update this to also push the intermediate image with the build results to make it easier for others to build ED.

@robkooper
Copy link
Contributor Author

I have to figure out we this can be fixed.Right now it has 22GB of disk storage, but when pulling the intel image we are left with 900Mb, not enough to build the docker image.
I see this on my own machine as well, i go from 44GB free storage to 28GB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdietze mdietze mdietze approved these changes

@mpaiao mpaiao Awaiting requested review from mpaiao

@pmoorcroft pmoorcroft Awaiting requested review from pmoorcroft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker image not being updated by GH actions
2 participants
@robkooper @mdietze