Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added methods for refactoring #52

Merged
merged 6 commits into from
Oct 27, 2022
Merged

added methods for refactoring #52

merged 6 commits into from
Oct 27, 2022

Conversation

Hafsa-Naeem
Copy link
Collaborator

@Hafsa-Naeem Hafsa-Naeem commented Oct 24, 2022

fixes #36, fixes #35

@Hafsa-Naeem Hafsa-Naeem changed the title added get_build_env method added methods for refactoring Oct 24, 2022
@Hafsa-Naeem
Copy link
Collaborator Author

fixes #36

tasks/build.py Show resolved Hide resolved
tasks/build.py Outdated Show resolved Hide resolved
tasks/build.py Show resolved Hide resolved
tasks/build.py Outdated Show resolved Hide resolved
tasks/build.py Show resolved Hide resolved
tasks/build.py Show resolved Hide resolved
tasks/build.py Show resolved Hide resolved
tasks/build.py Show resolved Hide resolved
tasks/build.py Show resolved Hide resolved
Copy link
Contributor

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested with boegel/software-layer#11 👍

@boegel boegel merged commit 0257288 into EESSI:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor build_easystack_from_pr into smaller functions Hardcode holding of jobs
3 participants