Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update status of PR comments when ingesting a tarball #146

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

update status of PR comments when ingesting a tarball #146

wants to merge 5 commits into from

Conversation

trz42
Copy link
Contributor

@trz42 trz42 commented May 13, 2023 •
edited
Loading

DRAFT because not the latest version has been fully tested yet (particularly the use of the PR comment id hasn't been tested yet).

  • this updates the PR comment corresponding to a build job in the software-layer
  • updates are
    • staged
    • approved / rejected
    • ingested
  • updates require additional settings in automated_ingestion.cfg, see automated_ingestion.cfg.example
    • ingest_staged
    • ingest_approved / ingest_rejected
    • ingest_done
  • if present it uses the PR comment id (provided by the bot via the uploaded metadata file, this requires add comment id to metadata uploaded to S3 eessi-bot-software-layer#182)
  • otherwise scans PR comments until one with a matching tarball name is found (can quickly consume GH API rate limit)

TODO

  • test with bot PR 182
  • add changes to scripts/ingest-tarball.sh

truib and others added 3 commits March 25, 2023 14:59
@truib
changes to work with NESSI
66aaec1 
- added config options for defining updates to PR comments in the software-layer
- added support to query S3 bucket on Minio server
- update PR comments in software-layer repo depending on deployment progress
- add more information to CernVM-FS server tag history
- add function to determine a PR comment using the name of a tarball
- add function to find an approval PR
- add function to determine the prefix of a tarball
- add function to update a PR comment in the software-layer repo
Merge branch 'main' of https://github.com/eessi/filesystem-layer into…
680060f 
… add_comments_to_software_PRs
@truib
store sw repo metadata in object and reuse it for more efficient GH i…
538554e 
…nteractions
@trz42 trz42 marked this pull request as draft May 13, 2023 19:58
@poksumdo poksumdo mentioned this pull request May 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trz42 @truib