Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{2023.06}[foss/2023b] WSClean 3.4 + DP3 6.0 #479
{2023.06}[foss/2023b] WSClean 3.4 + DP3 6.0 #479
Changes from 13 commits
f3f9721
f8cd2aa
eafbb6b
df089de
2ec41e1
d0ba0b7
5d797a9
a55826d
f63a4d8
7a0aceb
5c546ea
5b822a3
8892437
4e5f2db
3544073
0aea4b4
07296d3
86d8a36
790756b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably say something like
non-neoverse_v1
, but it's also okay to just leave the entireelse
clause out (as we don't do something similar in other hooks where we only apply something to a specific CPU target).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I decided to leave in the
else
clause, as the print message helped you figure out what was wrong in the previous build :)