Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{2023.06}[foss/2023b] WSClean 3.4 + DP3 6.0 #479

Merged
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,35 @@ easyconfigs:
- matplotlib-3.8.2-gfbf-2023b.eb:
options:
from-pr: 19552
- AOFlagger-3.4.0-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- arpack-ng-3.9.0-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- Armadillo-12.8.0-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- casacore-3.5.0-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- IDG-1.2.0-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- EveryBeam-0.5.2-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- DP3-6.0-foss-2023b.eb:
bedroge marked this conversation as resolved.
Show resolved Hide resolved
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- WSClean-3.4-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
30 changes: 27 additions & 3 deletions eb_hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@


CPU_TARGET_NEOVERSE_V1 = 'aarch64/neoverse_v1'
CPU_TARGET_AARCH64_GENERIC = 'aarch64/generic'
CPU_TARGET_AARCH64_GENERIC = 'aarch64/generic'

EESSI_RPATH_OVERRIDE_ATTR = 'orig_rpath_override_dirs'

Expand Down Expand Up @@ -160,6 +160,29 @@ def post_prepare_hook(self, *args, **kwargs):
POST_PREPARE_HOOKS[self.name](self, *args, **kwargs)


def parse_hook_casacore_disable_vectorize(ec, eprefix):
"""
Disable 'vectorize' toolchain option for casacore 3.5.0 on aarch64/neoverse_v1
Compiling casacore 3.5.0 with GCC 13.2.0 (foss-2023b) gives an error when building for aarch64/neoverse_v1.
See also, https://github.com/EESSI/software-layer/pull/479
"""
if ec.name == 'casacore':
tcname, tcversion = ec['toolchain']['name'], ec['toolchain']['version']
if (
LooseVersion(ec.version) == LooseVersion('3.5.0') and
tcname == 'foss' and tcversion == '2023b'
):
if get_cpu_architecture() == CPU_TARGET_NEOVERSE_V1:
t1mk1k marked this conversation as resolved.
Show resolved Hide resolved
ec['toolchainopts']['vectorize'] = False
print_msg("Changed toochainopts for %s: %s", ec.name, ec['toolchainopts'])
else:
print_msg("Not changing option vectorize for %s on non-AARCH64", ec.name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably say something like non-neoverse_v1, but it's also okay to just leave the entire else clause out (as we don't do something similar in other hooks where we only apply something to a specific CPU target).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I decided to leave in the else clause, as the print message helped you figure out what was wrong in the previous build :)

else:
print_msg("Not changing option vectorize for %s %s %s", ec.name, ec.version, ec.toolchain)
else:
raise EasyBuildError("casacore-specific hook triggered for non-casacore easyconfig?!")


def parse_hook_cgal_toolchainopts_precise(ec, eprefix):
"""Enable 'precise' rather than 'strict' toolchain option for CGAL on POWER."""
if ec.name == 'CGAL':
Expand Down Expand Up @@ -327,7 +350,7 @@ def pre_configure_hook_wrf_aarch64(self, *args, **kwargs):
if LooseVersion(self.version) <= LooseVersion('3.9.0'):
self.cfg.update('preconfigopts', "sed -i 's/%s/%s/g' arch/configure_new.defaults && " % (pattern, repl))
print_msg("Using custom preconfigopts for %s: %s", self.name, self.cfg['preconfigopts'])

if LooseVersion('4.0.0') <= LooseVersion(self.version) <= LooseVersion('4.2.1'):
self.cfg.update('preconfigopts', "sed -i 's/%s/%s/g' arch/configure.defaults && " % (pattern, repl))
print_msg("Using custom preconfigopts for %s: %s", self.name, self.cfg['preconfigopts'])
Expand Down Expand Up @@ -414,7 +437,7 @@ def pre_test_hook_ignore_failing_tests_netCDF(self, *args, **kwargs):
"""
cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')
if self.name == 'netCDF' and self.version == '4.9.2' and cpu_target == CPU_TARGET_NEOVERSE_V1:
self.cfg['testopts'] = "|| echo ignoring failing tests"
self.cfg['testopts'] = "|| echo ignoring failing tests"

def pre_test_hook_increase_max_failed_tests_arm_PyTorch(self, *args, **kwargs):
"""
Expand Down Expand Up @@ -579,6 +602,7 @@ def inject_gpu_property(ec):


PARSE_HOOKS = {
'casacore': parse_hook_casacore_disable_vectorize,
'CGAL': parse_hook_cgal_toolchainopts_precise,
'fontconfig': parse_hook_fontconfig_add_fonts,
'OpenBLAS': parse_hook_openblas_relax_lapack_tests_num_errors,
Expand Down
Loading