Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Highway hook: change optarch in pre_prepare_hook and reset it in post_prepare_hook #532

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Fix Highway hook: change optarch in pre_prepare_hook and reset it in post_prepare_hook #532

merged 3 commits into from
Apr 4, 2024

Conversation

bedroge
Copy link
Collaborator

@bedroge bedroge commented Apr 4, 2024 •
edited
Loading

Since the hook is changing a general build option (for setting optarch=GENERIC), it has to be reset afterwards. See #529 (review).

Tested it interactively for Haswell, Neoverse N1+V1. We could also let the bot do it, but then we'll need to add a rebuild easystack file.

@eessi-bot-aws eessi-bot-aws
Copy link

eessi-bot-aws bot commented Apr 4, 2024

Instance eessi-bot-mc-aws is configured to build:

  • arch x86_64/generic for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/generic for repo eessi-hpc.org-2023.06-software
  • arch x86_64/generic for repo eessi.io-2023.06-compat
  • arch x86_64/generic for repo eessi.io-2023.06-software
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-software
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-software
  • arch aarch64/generic for repo eessi.io-2023.06-compat
  • arch aarch64/generic for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-software

boegel
boegel requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I would just add a comment to help ensure that the condition is kept in sync in the pre/post hooks used for Highway...

eb_hooks.py Show resolved Hide resolved
eb_hooks.py Show resolved Hide resolved
bedroge and others added 2 commits April 4, 2024 20:33
@bedroge @boegel
Update eb_hooks.py
42e580b 
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
@bedroge @boegel
Update eb_hooks.py
3c4572c 
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
boegel
boegel approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit ababa60 into EESSI:2023.06-software.eessi.io Apr 4, 2024
33 checks passed
@boegel boegel added the 2023.06-software.eessi.io 2023.06 version of software.eessi.io label Apr 4, 2024
@bedroge bedroge deleted the fix_highway_optarch_hook branch April 4, 2024 19:31
@trz42 trz42 mentioned this pull request Apr 5, 2024
Open
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
2023.06-software.eessi.io 2023.06 version of software.eessi.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bedroge @boegel