-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround to fix broken curl installation #623
Conversation
Instance
|
Instance
|
Instance
|
Currently we ship |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but can you add a comment to mention that if curl we're removed from the compat layer we could do this via the cURL module file (or an Lmod hook) instead
…sed systems Co-authored-by: ocaisa <alan.ocais@cecam.org>
Add bigger comment Co-authored-by: ocaisa <alan.ocais@cecam.org>
@ocaisa Could you take a final check before merging this PR? |
I can't merge this because I don't know how to deploy it |
I'm not completely sure anymore if this can now be done with the bot (we did make some changes related to including the init scripts). Let's try it, and otherwise I can do it manually. |
bot: build repo:eessi.io-2023.06-software arch:x86_64/generic |
Updates by the bot instance
|
Updates by the bot instance
|
New job on instance
|
Looks like it actually worked 🎉. I also tested the fix on our Rocky 8 cluster: I got an error without the fix, but after applying the fix the curl command worked fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
As reported in the EESSI support portal issue #25, curl fails in RHEL 8 and above systems as CA files location differs. Works for all rhel based systems as I could reproduce the issue also in them.
I am not a fan of hardcording in the init script but investigating the issue I haven't found a more suitable way to solve it for our use case. Maybe another solution would be to add a modlua footer exporting this variable in the affected modules?