Fix failing tests in tools_controller_spec.rb #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparr
commented
Apr 4, 2024
| @@ -66,8 +66,7 @@ | |||
| it "should redirect to ActionPage#service_uri(service) if email has custom recipients" do | |||
| service = "gmail" | |||
| uri = "https://composeurl.example.com" | |||
| expect(ActionPage).to receive(:find_by_id) { custom_email_campaign.action_page } | |||
There was a problem hiding this comment.
we dont really need to mock this. its ok to let it hit the database
jparr
commented
Apr 4, 2024
| @@ -93,7 +91,6 @@ | |||
| Rails.application.secrets.google_civic_api_key = "test-key-for-civic-api" | |||
|
|
|||
| stub_request(:get, "http://civic.example.com/?address=%20&includeOffices=true&key=test-key-for-civic-api&levels=administrativeArea1&roles=legislatorUpperBody") | |||
| .with(headers: request_headers) | |||
There was a problem hiding this comment.
I dont think we need to match on header specific values. This would be valuable if the controller action had different execution paths based on header values. It broke on my machine because of different user agents.
esoterik
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.