fix congress message spec #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparr
commented
Apr 4, 2024
| @@ -69,8 +69,7 @@ def background_submit(test: false) | |||
| return unless valid? | |||
|
|
|||
| @forms.each do |f| | |||
| f.delay.fill(attributes_for(f.bioguide_id), campaign.campaign_tag, | |||
| test: test) | |||
| f.delay.fill(attributes_for(f.bioguide_id), campaign.campaign_tag, test) | |||
There was a problem hiding this comment.
Looks like rubocop 'fixed' this here: 9ecfc7d
There was a problem hiding this comment.
I need to add something so rubocop doesnt make the same mistake again
There was a problem hiding this comment.
I got rubocop running and it did not try to fix this again so I think its good to go!
jparr
commented
Apr 4, 2024
| @@ -30,6 +30,12 @@ | |||
| mocks.verify_partial_doubles = true | |||
| end | |||
|
|
|||
| config.around(:each, :run_delayed_jobs) do |example| | |||
There was a problem hiding this comment.
added this nice helper. it runs the jobs synchronously so you get error reporting inline with the test/logging output
-looks like rubocop erroneously 'fixed' this method
jparr
force-pushed
the
jparr/fix-congress-message-spec
branch
from
29086c4
to
33c81e9
Compare
esoterik
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a helper for better delayed job error reporting