fix feature specs #910
Merged
fix feature specs #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparr
commented
Apr 5, 2024
| @@ -31,6 +31,7 @@ | |||
| Capybara.server = :puma | |||
| Capybara.javascript_driver = :selenium_chrome_headless | |||
| Capybara.enable_aria_label = true | |||
| Capybara.disable_animation = true | |||
There was a problem hiding this comment.
This should make the weird timing problems in admin/action_creation_spec go away. I didnt remove everything in there but it should remove the need for sleeps.
jparr
commented
Apr 5, 2024
| end | ||
|
|
||
| def next_section | ||
| click_on "Next" | ||
| sleep 0.05 | ||
| end | ||
|
|
||
| def skip_banner_selection | ||
| expect(page).to have_selector("#images", visible: true, wait: 5) |
There was a problem hiding this comment.
Doing an expect like this is a better way to make sure a page is settled before calling actions that will error if an element isnt visible. Even though I'm waiting for potentially 5 seconds it will automatically continue as soon as it resolves true. You also know that the element isnt available which is a more useful error than what shows if it cant fill in an input.
8 tasks
esoterik
approved these changes
Apr 8, 2024
| end | ||
|
|
||
| def next_section | ||
| click_on "Next" | ||
| sleep 0.05 | ||
| end | ||
|
|
||
| def skip_banner_selection | ||
| expect(page).to have_selector("#images", visible: true, wait: 5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to database cleaner config fixed a failing testing in features/action_pages/call_action_spec for me.
We should consider removing it as DatabaseCleaner is not usually necessary in new rails versions.