Upgrade Sentry #914
Draft
Upgrade Sentry #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see: #913
jparr
commented
Apr 9, 2024
| config.dsn = Rails.application.secrets.sentry_dsn | ||
| end | ||
| Sentry.init do |config| | ||
| config.dsn = Rails.application.secrets.sentry_dsn |
There was a problem hiding this comment.
Need to init in order not to error in tests. It won't send events if sentry_dsn is empty.
jparr
commented
Apr 9, 2024
| def set_context | ||
| Raven.extra_context(message: request.body.read) | ||
| request.body.rewind | ||
| end |
There was a problem hiding this comment.
This moved to being called inside of the .with_scope block
|
A minor heads up that our internal Sentry instance is Sentry 9.1.2 which doesn't support the new |
8 tasks
I'll mark this as a draft so it doesnt get merged by accident. @alexymik do you happen to know if upgrading the sentry-raven gem would be compatible? I havent found a compatibility list yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #913