Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Audit default_off="mismatched" rulesets. #13088

Closed
bardiharborow opened this issue Oct 14, 2017 · 15 comments
Closed

Audit default_off="mismatched" rulesets. #13088

bardiharborow opened this issue Oct 14, 2017 · 15 comments
Labels
good volunteer task

Comments

@bardiharborow
Copy link
Contributor

bardiharborow commented Oct 14, 2017 •
edited

Type: other

The following default_off="mismatched" rulesets pass a curl -I https://host/ scan for at least one host (full host list):
This was referenced Oct 14, 2017
Merged
Merged
Merged
@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

4 similar comments
@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

@bardiharborow bardiharborow mentioned this issue Oct 14, 2017
Merged
@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

This was referenced Oct 14, 2017
Merged
Merged
Merged
@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

This was referenced Oct 14, 2017
Closed
Merged
Merged
@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

2 similar comments
@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

This was referenced Oct 15, 2017
Merged
Merged
@cschanaj
Copy link
Collaborator

@bardiharborow Start.me.xml is not default_off in master, see #13151 for Start.me-problematic.xml

@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

@bardiharborow
Copy link
Contributor Author

@cschanaj a bug in how I mapped hosts to rulesets means that any ruleset with the affected host will be picked up, regardless of if they are default_off or not, but that's probably good anyway because it catches issues like that.

@cschanaj
Copy link
Collaborator

@bardiharborow I agree that you don't have to fix this. Thank you for your explanations!!

This was referenced Oct 15, 2017
Merged
Closed
Merged
@https-everywhere-bot
Copy link

Thanks! Your edit helped me out. I'll take it from here now.

This was referenced Oct 29, 2017
Merged
Merged
@J0WI J0WI mentioned this issue Jun 15, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good volunteer task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bardiharborow @J0WI @cschanaj