New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ShareMeNot functionality #196
Conversation
Conflicts: src/webrequest.js
This is awesome, thanks so much! Can you show me an example of a page where it messes with the layout? I will have to do some testing and if it does mess up the layout as you say I will want to make an options page for privacy badger before I merge this pull request. |
Hmm, I can't find a great example at the moment. Here's a page where the replacement buttons look weird (scroll to the bottom), but I just realized they look a little weird normally as well: http://www.webmonkey.com/2010/04/adding-facebook-like-buttons-to-your-site-is-damn-easy/. I do occasionally get complaints from ShareMeNot users. |
It looks like that site is wonky with or without ShareMeNot, I will keep
On 06/09/2014 10:10 PM, Franzi Roesner wrote:
|
I think those buttons don't involve third-party requests, just local css, On Tue, Jun 10, 2014 at 11:53 AM, Cooper Quintin notifications@github.com
|
Cool, that makes sense. This looks fine so far in my testing. I will add an option to turn it off when I make an options page for privacy badger. |
Integrate ShareMeNot functionality. Fixes #84
This branch supports ShareMeNot's social widget replacement functionality. Buttons are replaced if the corresponding domains are blocked by Privacy Badger, and those domains are temporarily unblocked if the button is clicked.
This functionality is enabled by default (Utils.isSocialWidgetReplacementEnabled() just returns true), but should be linked to a user-facing setting.
Test page: http://sharemenot.cs.washington.edu/Test%20Installation.shtml.
Caveat: Button replacement messes with webpage layout on some pages, so this should likely be an opt-in feature.