Add surrogate-based replacement for YouTube JS API #2852
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2849. Follows up on #2805 and #2280.
To be followed up with another round of reviewing error reports and fixing the major remaining issues so that we can remove YouTube from the yellowlist (#1593). Should also look into handling
youtube-nocookie.com
.Working YT JS API examples:
YT.Player
API methods)window.onYouTubeIframeAPIReady
)YT.PlayerState
in surrogate)/player_api
endpoint)Examples with issues:
img.youtube.com
thumbnails)Broken examples:
videoId
in initialPlayer
config)Non-JS API YT broken examples:
img.youtube.com
thumbnails)youtube-nocookie.com
, some sort of z-index (?) issue where replacement happens but our placeholder is covered up by page's own video placeholder)Brave/DDG test pages: