Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add surrogate-based replacement for YouTube JS API #2852

Merged
merged 5 commits into from
Sep 26, 2022

Conversation

ghostwords
Copy link
Member

@ghostwords ghostwords commented Sep 16, 2022

Fixes #2849. Follows up on #2805 and #2280.

To be followed up with another round of reviewing error reports and fixing the major remaining issues so that we can remove YouTube from the yellowlist (#1593). Should also look into handling youtube-nocookie.com.

Working YT JS API examples:

Examples with issues:

Broken examples:

Non-JS API YT broken examples:

Brave/DDG test pages:

@ghostwords ghostwords added widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets surrogates Replacement blank/noop/dummy/neutered versions of tracking scripts used to avoid site breakages labels Sep 16, 2022
@ghostwords ghostwords force-pushed the youtube-surrogate branch 4 times, most recently from 6dd56dc to 48a494e Compare September 22, 2022 15:31
@ghostwords ghostwords marked this pull request as ready for review September 22, 2022 21:06
@ghostwords ghostwords merged commit 40faeb0 into master Sep 26, 2022
@ghostwords ghostwords deleted the youtube-surrogate branch September 26, 2022 19:11
ghostwords added a commit that referenced this pull request Dec 6, 2022
This reverts commit dad26a1

Fixes #2864

Following up on #2852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
surrogates Replacement blank/noop/dummy/neutered versions of tracking scripts used to avoid site breakages widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Youtube widget on Aljazeera.com
1 participant