Add tests for popup #964
Merged
Add tests for popup #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like github / travis was able to handle the rebase for you. Once I merged that PR and reran the tests they pass. This looks good to me modulo the issues you mentioned so I'm gonna go ahead and merge. Thanks for the commit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #878 but it has some shortcomings. From what I can tell it's not possible to open the popup normally with Selenium because Selenium can only interact with a webpage and not the other browser elements.
This PR works around that by opening the popup page directly and testing some of its functionality. Unfortunately this means the most critical part of the popup, the tracker list, isn't being tested. Maybe there's a way around that?
Before this can be merged, either I need to rebase after PR 959 is merged or I need to remove the check for opening the tracker link in a new window.