Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please implement Chrome settings sync #645

Closed
axelcostaspena opened this issue Oct 27, 2015 · 10 comments
Closed

Please implement Chrome settings sync #645

axelcostaspena opened this issue Oct 27, 2015 · 10 comments

Comments

@axelcostaspena
Copy link

So our custom block rules are synced across a single user's several PCs.

https://developer.chrome.com/extensions/storage#property-sync

@charlesprogrammr
Copy link

It would be useful if settings could be utilized from multiple browsers on the same machine, as well. I have Chrome, Chromium, Chrome Canary, Whitehat Aviator on my machine, using each for separate tasks (e.g. banking, browsing, etc.) to breakup any tracking by insincere parties. If cookies from one would trip blocking for the others, it would be a very good thing.
I have other browsers to check webpage development with too, not just Chrome based browsers. Even getting just the Chrome browsers inter-operable would help.

@cooperq
Copy link
Contributor

cooperq commented Oct 30, 2015

So this isn't as easy as it looks on the surface, using the chrome sync api severely limits the amount of data that we can store, right now we are using a bit more data than can be stored with chrome sync, we would have to rethink how we store user data if we wanted to take this approach.

as for being able to import/export settings see #121

@ghostwords
Copy link
Member

ghostwords commented Oct 16, 2017

Unfortunately, chrome.storage.sync is limited to around 100 KB, which is unlikely to be enough to fit your Badger's learning database.

@jokeyrhyme
Copy link

Perhaps we can use Google Drive's Application Data for this purpose?
https://developers.google.com/drive/v3/web/appdata

@ghostwords
Copy link
Member

I think that's for Android apps, while what we have is a Chrome extension.

@jokeyrhyme
Copy link

@ghostwords there are JavaScript examples, and it's mostly REST APIS, so I think we can use them if we have a button on the settings view that requests access to the user's Drive
https://developers.google.com/drive/v3/web/about-auth
scope = https://www.googleapis.com/auth/drive.appfolder

One possible complication is what happens if you sync data from 2 browser instances at nearly the same time? Is this a common case? Does Google Drive's conflict resolution work in the Application Data folder? But does Chrome Sync offer this sort of functionality anyway?

@knwpsk
Copy link

knwpsk commented Jul 20, 2018

(I'm new, so please be gentle or guide me)
Also trying to sync my PB whitelist settings across machines and browsers.
AND... would like to sync PB settings across two different user-instances of Chrome on the same machine (work persona and home persona).

If this is "too hard" to develop using Chrome framework as discussed above, I would like to have a way to sync the settings using Dropbox, or Google Drive Sync, or BTSync, etc. So, maybe I could turn on an option in PB settings that says, "Each time I make a change, automatically export my settings to a file in a designated directory." Then I just set up that directory to synchronize. On the other end, tell PB "Each time I start Chrome, check that directory for a new file and import it."

@ghostwords
Copy link
Member

ghostwords commented Jul 20, 2018

Hello! Could you go a bit into why you would like to sync Badger settings automatically?

If one of your Badgers learned different domains from another of your Badgers, that's OK, I don't see a problem. The big idea is to stop continuous tracking of your Web activities. If a tracker sees you twice before your Badger learns to block it, no big deal, I think. (There is also manual export and import for extreme situations such as new installations.)

If you find yourself customizing the sliders much, this is something we'd like to move away from as we want Privacy Badger to be an install-and-forget extension. (I suggest using the "Disable Privacy Badger for This Site" button instead.)

Now if you'd like to keep your list of websites where Privacy Badger is disabled in sync, that is something we may want to implement sometime. There is a clear use case (it's frustrating to have to "teach" your different Badgers which websites to leave alone over and over), plus the Chrome API should support doing this (as the list of disabled sites will likely fit within API limits).

@knwpsk
Copy link

knwpsk commented Jul 20, 2018

Ghostwords -- yes, you got it, I want to sync my list of sites for which PB is "disabled" (that's what I meant by "whitelist" in my comments).
And maybe that's particularly important, because one might guess that -- if we just want to sync that list -- it could be done within the Chrome data size limit.
You're correct again, when you implied that I really don't mess with the sliders much. I usually just whitelist a site if (a) i trust it, and (b) something is broken by the blockers.

@ghostwords
Copy link
Member

Closing in favor of #2110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants