Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for popup to selenium tests. #878

Closed
cowlicks opened this issue Jul 8, 2016 · 3 comments
Closed

Add tests for popup to selenium tests. #878

cowlicks opened this issue Jul 8, 2016 · 3 comments

Comments

@cowlicks
Copy link
Contributor

cowlicks commented Jul 8, 2016

No description provided.

@cowlicks cowlicks mentioned this issue Jul 8, 2016
Merged
@cooperq cooperq closed this as completed Aug 11, 2016
@cowlicks
Copy link
Contributor Author

@cooperq it doesn't look like this has been fixed. Is there a reason why we shouldn't add selenium tests for the popup?

@cooperq cooperq reopened this Aug 16, 2016
@cooperq
Copy link
Contributor

cooperq commented Aug 16, 2016

Nope! I erroniously closed it thinking it was part of the incognito mode ticket , my mistake!

@rcutmore rcutmore mentioned this issue Oct 12, 2016
Merged
@cowlicks
Copy link
Contributor Author

Closed by #964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cooperq @cowlicks