Skip to content
This repository has been archived by the owner on Nov 17, 2017. It is now read-only.

Privacy Badger blocks KeeFox #596

Closed
brainpower opened this issue Sep 8, 2015 · 5 comments
Closed

Privacy Badger blocks KeeFox #596

brainpower opened this issue Sep 8, 2015 · 5 comments

Comments

@brainpower
Copy link

KeeFox uses WebSockets to communicate with a server listening on 127.0.0.1.
After some time KeeFox was unable to connect to this server.

I traced it to Privacy Badger, which actually blocked 127.0.0.1 !
After manually allowing 127.0.0.1 KeeFox started to work normally again.

I've whitlistet localhost for now, but this was quite difficult to track this down and
I cant see how it's sensible to block localhost as tracker.
Anyone tracking himself: it's his own problem...

@cooperq
Copy link
Contributor

cooperq commented Sep 8, 2015

Agreed privacy badger should not ever block localhost.

@cooperq cooperq added the bug label Sep 8, 2015
@cooperq cooperq added this to the 1.1 milestone Sep 8, 2015
@fiskr
Copy link

fiskr commented Sep 22, 2015

I would be interesting in solving this issue.

I'm trying to figure out the best way to do that - perhaps to add localhost to local storage.domainExceptionSites when installed?

This would add flexibility for the edge case when someone would want to block localhost.

@cooperq
Copy link
Contributor

cooperq commented Sep 22, 2015

So adding it to storage.domainExceptionSites will disable it when localhost is the first party, which is maybe not what @brainpower is describing. I think the situation is that localhost was getting blocked as a third party domain, which probably shouldn't happen ever. I think the solution to this would be to check if the domain is localhost, and ignore it if so, in contentpolicy.js

@fiskr
Copy link

fiskr commented Sep 22, 2015

Ah, one could just check the location in isBlockableRequest then?
I can make a pull request to fix this if you'd like.

@cooperq
Copy link
Contributor

cooperq commented Sep 23, 2015

Yea I think we should just check for localhost and 127.0.0.1 in isBlockableRequest

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants