Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile for checker #222

Merged
merged 2 commits into from
May 6, 2019
Merged

Dockerfile for checker #222

merged 2 commits into from
May 6, 2019

Conversation

vbrown608
Copy link
Collaborator

@vbrown608 vbrown608 commented May 1, 2019

Depends on #206

I decided to give the checker its own Dockerfile because it builds a different binary and could have different dependencies. We could build two binaries in the existing Dockerfile but it seemed more consistent with the Docker philosophy to have a single-application image.

This can run daily scans with a checker/docker-compose.yml like

services:
    app:
        build: .
        environment:
          - CONNECTION_POOL_SIZE=32
        volumes:
          - ./shared:/shared
        command: /bin/sh -c 'env >> /etc/environment && crontab /shared/check.cron && crond -f'

and a checker/shared/check.cron like

0 15 * * * /go/bin/starttls-check --file=/shared/majestic_million.csv --column=2 --aggregate=true >> /shared/stats.csv

I'd like to commit those to a deploy repo managed by techops.

@sydneyli
Copy link
Contributor

sydneyli commented May 3, 2019

The changes from the last two commits look good to me.

@sydneyli sydneyli merged commit db0a3b4 into master May 6, 2019
@sydneyli sydneyli deleted the majestic-scan-tweaks branch May 6, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants