Text encoding parameter #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApolloZhu
reviewed
May 1, 2020
| @@ -692,9 +703,10 @@ public class EFQRCodeGenerator: NSObject { | |||
| return nil | |||
| } | |||
| let finalInputCorrectionLevel = inputCorrectionLevel | |||
| let finalContentEncoding = contentEncoding | |||
EyreFree
force-pushed
the
master
branch
4 times, most recently
from
8f2024e
to
b161195
Compare
EyreFree
approved these changes
Sep 11, 2020
|
Thanks for your contribution, 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
contentEncodingparameter togenerateQRCodeallowing the user to specify which text encoding method to use when converting thecontentstring intoData. The default encoding method is UTF-8, the same as the encoding method used before.This only adds the parameter to the function and does not add an option in any of the example app interfaces.
Closes #89