Bytes Length is confusing

[blankdots]

Description

When retrieving the file from DataEdge the implementation extracts 16 bytes https://github.com/EGA-archive/ega-data-api/blob/master/ega-data-api-dataedge/src/main/java/eu/elixir/ega/ebi/dataedge/service/internal/RemoteFileServiceImpl.java#L782, a crypt4gh needs to extract 32 bytes as shown here: https://github.com/EGA-archive/ega-data-api/blob/test/m4/ega-data-api-dataedge/src/main/java/eu/elixir/ega/ebi/dataedge/service/internal/RemoteFileServiceImpl.java#L782

Then there are bytes removed again here: https://github.com/EGA-archive/ega-data-api/blob/test/m4/ega-data-api-dataedge/src/main/java/eu/elixir/ega/ebi/dataedge/service/internal/RemoteFileServiceImpl.java#L159

Then there is this prefix: https://github.com/EGA-archive/ega-data-api/blob/test/m4/ega-data-api-dataedge/src/main/java/eu/elixir/ega/ebi/dataedge/service/internal/RemoteFileServiceImpl.java#L774 of 16 bytes.

The explanation is here: https://github.com/EGA-archive/ega-data-api/blob/test/m4/ega-data-api-dataedge/src/main/java/eu/elixir/ega/ebi/dataedge/service/internal/RemoteFileServiceImpl.java#L188-L190 ?

The implementation is a confusing and could be better in the way it handles distributing plain and encrypted files.

Definition of Done

Figure out a flexible solution in dealing with the file distribution via DataEdge.

How to test

Unit test and integration tests for different file formats, encrypted or not with different algorithms.

[juhtornr]

@anandmohan777 can replicate this and will provide details

[juhtornr]

and @omllobet as well.

[blankdots]

Let us finish this as well: #131 and we can close this.