Fixing bytes length for localEGA profile #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2019 10:59
integration test for dataedge.
anandmohan777
added
bug
blankdots
previously approved these changes
Apr 26, 2019
omllobet
reviewed
Apr 29, 2019
...src/main/java/eu/elixir/ega/ebi/dataedge/service/internal/LocalEGAFileLengthServiceImpl.java
Outdated
Show resolved
Hide resolved
AlexanderSenf
approved these changes
May 1, 2019
AlexanderSenf
previously approved these changes
May 1, 2019
anandmohan777
dismissed stale reviews from AlexanderSenf and blankdots
via
e958d3d
anandmohan777
changed the title
anandmohan777
force-pushed
the
bugfix/byte_length_missing
branch
from
b18864b
to
2eb874e
Compare
stored in a LocalEga, the sha256sum is added at the beginning so the length would be -32. Also adding new file for integration test
anandmohan777
force-pushed
the
bugfix/byte_length_missing
branch
from
2eb874e
to
536544f
Compare
blankdots
approved these changes
May 3, 2019
omllobet
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
In localEGA, removing 32 bytes from the actual file size because when the file is stored in S3, the sha256sum is added at the beginning so the length would be -32. This PR fixes the bug.
Also adding some files related to fix integration tests.
Related issues:
#93