Remove hard dependency to jnr-fuse and changing version #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorizci
suggested changes
Jan 29, 2020
fuseclient.sh
Outdated
| PATH_TO_JAR=target/ega-fuse-1.0-SNAPSHOT.jar | ||
| PROCESSCNT=$(ps x |grep -v grep |grep -c "ega-fuse-1.0-SNAPSHOT.jar") | ||
| PID=$(ps aux | grep "ega-fuse-1.0-SNAPSHOT.jar" | grep -v grep | awk '{print $2}') | ||
| PATH_TO_JAR=target/ega-fuse-0.1.0.jar |
There was a problem hiding this comment.
You have the variable there but then you ignore it in the rest of the script, if you use that variable you won't need to change version number on so many places every time we change the version.
|
Also, change documentation to refect the version of the jar. |
jorizci
suggested changes
Jan 30, 2020
jorizci
approved these changes
Jan 30, 2020
bela-juhasz
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.