Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multivoting visualization #58

Merged
merged 14 commits into from
Dec 17, 2023

Conversation

MartaInes
Copy link
Collaborator

In this PR is added the frontend for the single and multioption voting.

@MartaInes MartaInes added enhancement New feature or request High priority This shold be solved as soon as possible labels Dec 16, 2023
@MartaInes MartaInes self-assigned this Dec 16, 2023
@MartaInes MartaInes linked an issue Dec 16, 2023 that may be closed by this pull request
@JMGarCas JMGarCas self-assigned this Dec 16, 2023
Copy link

codacy-production bot commented Dec 16, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.05% 96.30% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d50e29c) 3020 2682 88.81%
Head commit (e5321c6) 3071 (+51) 2729 (+47) 88.86% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#58) 54 52 96.30%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link
Collaborator

@auroranavas auroranavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a comment requesting for a change for mutiple option voting. Single option voting does work.

decide/booth/templates/booth/booth.html Outdated Show resolved Hide resolved
@auroranavas auroranavas self-requested a review December 17, 2023 18:58
Copy link
Collaborator

@auroranavas auroranavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both multioption and single voting work. The tests run correctly. Congrats on this feature!

Copy link

@AntonioRodriguezRuiz AntonioRodriguezRuiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@AntonioRodriguezRuiz AntonioRodriguezRuiz merged commit f9b4167 into develop Dec 17, 2023
7 checks passed
@AntonioRodriguezRuiz AntonioRodriguezRuiz deleted the feature/multivoting-visualization branch December 17, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request High priority This shold be solved as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature -> zambrano-2 -> multivoting visualization
4 participants