Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/priority voting visualization #76

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

pabpercab1
Copy link
Collaborator

@pabpercab1 pabpercab1 commented Dec 18, 2023

This pull request aims to provide a frontend capability to the priority voting type. The result is the one that you can see in the screenshot.
Captura de pantalla 2023-12-18 a las 22 46 19
The code edited is located in booth.html

@pabpercab1 pabpercab1 linked an issue Dec 18, 2023 that may be closed by this pull request
@pabpercab1 pabpercab1 added enhancement New feature or request High priority This shold be solved as soon as possible labels Dec 18, 2023
@pabpercab1 pabpercab1 marked this pull request as ready for review December 18, 2023 21:54
Copy link

codacy-production bot commented Dec 18, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (acf94f2) 3352 3000 89.50%
Head commit (a6e3530) 3352 (+0) 2999 (-1) 89.47% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#76) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@pabpercab1 pabpercab1 closed this Dec 19, 2023
@MartaInes MartaInes reopened this Dec 19, 2023
Copy link

@AntonioRodriguezRuiz AntonioRodriguezRuiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check when voting that the list of priorities has all unique numbers. You can do this by turning them into sets and checking that the lenght of the set is the same as the list
image
image

Copy link

@AntonioRodriguezRuiz AntonioRodriguezRuiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Collaborator

@Marchabar Marchabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@AntonioRodriguezRuiz AntonioRodriguezRuiz merged commit 0ecf8e6 into develop Dec 19, 2023
7 checks passed
@AntonioRodriguezRuiz AntonioRodriguezRuiz deleted the feature/priority-voting-visualization branch December 19, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request High priority This shold be solved as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature -> zambrano-2 -> priority voting frontend
4 participants