V0.1.0 rc #12
V0.1.0 rc #12
Conversation
Add Travis timeout to fix #5
The data provided by Lavoisier is a bit too complex to handle neatly directly inside Ansible. The structure is too deep to be able to efficiently loop over, and the json query becomes difficult to read. For these reasons, I've decided to parse the data out of band with a small python script in files/ which writes a cached data file in JSON format.
The VO data is added to this repository, even though I am in two minds about it. The pros are as follows: - The task which configures lsc and vomses files needs this data locally. - Re-using this role with other ones in playbook means that the data needs to be cached, since the user will not know a-priori that the data is needed - we can do change-control on the data The cons are as follows: - there is a risk that the cached data is different from the "live" data exposed by lavoisier - the repository becomes very large - trivial changes to the file become difficult to maintain (beautifying) - Caching the data is a manual process which could be easily forgotten by admins (can be mitigated with a git hook)
| try: | ||
| data = requests.get(url).json() | ||
| except UserWarning as e: | ||
| print e |
There was a problem hiding this comment.
This won't work on python 3!
There was a problem hiding this comment.
I indeed was troubled by this too. Since Ansible is 2.7, I thought it might be better to stick to a consistent version. Given the upcoming deprecation of 2.7, I guess it won't hurt to have a python3-compatible one too. I'll open an issue for the next milestone.
README.md
Outdated
| @@ -37,7 +94,7 @@ passed in as parameters) is always nice for users too: | |||
| - hosts: servers | |||
| roles: | |||
| - { role: brucellino.umd, release: 4, } | |||
There was a problem hiding this comment.
should this be EGI-Foundation.umd?
There was a problem hiding this comment.
Well spotted - it's updated in e5015cc
| @@ -36,8 +110,8 @@ passed in as parameters) is always nice for users too: | |||
| ```yaml | |||
| - hosts: servers | |||
| roles: | |||
| - { role: brucellino.umd, release: 4, } | |||
| - { role: EGI-Foundation.voms-client, vos: 'atlas' } | |||
| - { role: EGI-Foundation.umd, release: 4 } | |||
There was a problem hiding this comment.
Apparently it only works with underscore: EGI_Foundation.umd
There was a problem hiding this comment.
This would be the case if we were using the search API on galaxy. However, the requirements.yml at the moment is using the git fetcher (since 52ac706).
When the Galaxy API has stabilised, we can move back.
|
Thanks for the review guys. I'm going to go ahead and merge. |
Working version of the role.