Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to openldap 2.5+ #42

Merged
merged 21 commits into from Dec 15, 2022
Merged

Migrate to openldap 2.5+ #42

merged 21 commits into from Dec 15, 2022

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Dec 4, 2022

Summary

Issue #41 describes how updating to openldap 2.5 or later breaks bdii due to the removal of the hdb slapd backend used by bdii. The issue is now more urgent, since RedHat Enterprise Linux 9, and derivatives such as CentOS Stream 9 and Rocky Linux 9, uses openldap 2.6.

This PR proposes a migration to the mdb slapd backend. The changes were first proposed by andreas.haupt@desy.de in a bugzilla ticket for the EPEL 9 version of bdii in the RedHat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2150344


Related issue: #41

The bdb and hdb backends were removed from slapd in openldap 2.5
@ellert ellert requested review from a team as code owners December 4, 2022 11:00
@gwarf gwarf self-assigned this Dec 7, 2022
debian/rules Show resolved Hide resolved
@gwarf
Copy link
Member

gwarf commented Dec 7, 2022

Thanks a lot @ellert!
We have seen that in https://src.fedoraproject.org/rpms/bdii/c/68201bd332defa7cd8fba764c5b2ade85cdd08fe?branch=rawhide you are using a patch to do this only for >= C9, I guess we may want to do the same.

So can we borrow your patch? or maybe you want to add it yourself to this PR?

We have discussed this with @andrea-manzi and we plan to:

  • build a version for CentOS 7 (and CentOS 8 Stream in case one wants it) with python3 and hdb support
  • build a version for CentOS 9 Stream with python3 and mdb
  • To be clarified what we do for debian, as debian bullesye is still using slapd 2.4, so it may be safer to also use mdb conditionnaly on debian, what do you think? For debian we could also add building to the GitHub actions pipeline. How do you want to proceed with this?

@gwarf
Copy link
Member

gwarf commented Dec 7, 2022

You should also have received an invitation to join the EGI Federation org, if you accept it would grant you write rights to this repo and to a bunch of other BDII repos, I guess it makes sense.

@ellert
Copy link
Contributor Author

ellert commented Dec 8, 2022

So can we borrow your patch? or maybe you want to add it yourself to this PR?

The patch in the Fedora/EPEL build is generated from the git commit in the PR:

git format-patch a3312f9~1..a3312f9

@gwarf gwarf requested a review from enolfc December 14, 2022 14:02
Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gwarf gwarf merged commit 94131c8 into EGI-Federation:master Dec 15, 2022
This was referenced Dec 15, 2022
@ellert ellert deleted the mdb branch December 15, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants