Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network info #151

Merged
merged 7 commits into from
Feb 21, 2019
Merged

Fix network info #151

merged 7 commits into from
Feb 21, 2019

Conversation

gwarf
Copy link
Member

@gwarf gwarf commented Feb 21, 2019

Update parsing of inbound/outbound network info of images.
Fix #149.

@gwarf gwarf added the bug label Feb 21, 2019
@gwarf gwarf added this to the 1.0 milestone Feb 21, 2019
@gwarf gwarf self-assigned this Feb 21, 2019
@gwarf gwarf added this to To do in GLUE 2.1 via automation Feb 21, 2019
@gwarf gwarf requested a review from enolfc February 21, 2019 10:08
@gwarf gwarf marked this pull request as ready for review February 21, 2019 11:20
enolfc
enolfc requested changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@enolfc enolfc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gwarf ! A suggestion to avoid the duplicated code is provided, could you take a look?

cloud_info_provider/utils.py Outdated Show resolved Hide resolved
etc/templates/compute.glue21 Outdated Show resolved Hide resolved
enolfc
enolfc approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging.

@enolfc
Copy link
Contributor

enolfc commented Feb 21, 2019

waiting for codacy....

@gwarf gwarf merged commit d69e613 into EGI-Federation:master Feb 21, 2019
GLUE 2.1 automation moved this from To do to Done Feb 21, 2019
@gwarf gwarf mentioned this pull request Mar 4, 2019
Closed
@gwarf gwarf deleted the fix_network_info branch November 19, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enolfc enolfc enolfc approved these changes

Assignees

@gwarf gwarf

Labels
bug
Projects
GLUE 2.1
  
Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gwarf @enolfc