Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ignore errors option #217

Merged
merged 7 commits into from
Feb 22, 2021
Merged

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Feb 15, 2021

Summary

Add option to ignore errors when getting information for share, so cloud-info-provider can still produce results for other shares configured in the resources. This avoids crashes although can hide errors


Related issue :

Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Should we allow to log those errors somewhere, so that one can see what failed?

@enolfc
Copy link
Contributor Author

enolfc commented Feb 22, 2021

LGTM.
Should we allow to log those errors somewhere, so that one can see what failed?

Good point, let's add it in this same PR

@enolfc enolfc force-pushed the ignore-errors branch 2 times, most recently from c3decd1 to 5df1ec7 Compare February 22, 2021 10:58
@enolfc enolfc merged commit d9db168 into EGI-Federation:master Feb 22, 2021
@enolfc enolfc deleted the ignore-errors branch February 22, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants