Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh without client secret #222

Merged
merged 3 commits into from
May 13, 2021
Merged

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented May 11, 2021

Summary

Allow the refresh of tokens without the client_secret for the new fedcloud client


Related issue :

@gwarf
Copy link
Member

gwarf commented May 11, 2021

Duh, an error on the opennebula part:


Screenshot 2021-05-11 at 14 10 24

@enolfc
Copy link
Contributor Author

enolfc commented May 11, 2021

Duh, an error on the opennebula part:

saw that a bit of a pain :(

@gwarf
Copy link
Member

gwarf commented May 11, 2021

Duh, an error on the opennebula part:

saw that a bit of a pain :(

So it's a bit weird to see the linter fail on this (I mean, it's a quite advanced linting check!). Looking around I saw mentions of updating/reinstalling cleanly six, but...
If we think that our others tests are fine we can merge this.
Any plan to decommission/drop the opennebula part?

@enolfc
Copy link
Contributor Author

enolfc commented May 12, 2021

Duh, an error on the opennebula part:

saw that a bit of a pain :(

So it's a bit weird to see the linter fail on this (I mean, it's a quite advanced linting check!). Looking around I saw mentions of updating/reinstalling cleanly six, but...

Should be ok now, just disabled mypy in that line, no need to get crazy on this one.

If we think that our others tests are fine we can merge this.
Any plan to decommission/drop the opennebula part?

honestly I think we are not paying much attention there so we should do something about it, either properly maintain it, or drop it. My preference since long was trying to split providers into different packages but that also requires work on the base.

Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enolfc enolfc merged commit 0e20568 into EGI-Federation:master May 13, 2021
@enolfc enolfc deleted the refresh-PKCE branch May 13, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants