Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for endpoints in GOCDB #234

Merged
merged 11 commits into from
Mar 20, 2023
Merged

Add support for endpoints in GOCDB #234

merged 11 commits into from
Mar 20, 2023

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Mar 17, 2023

Summary

Sites may choose to add URLs to the endpoints in GOCDB. Adding support for this case.

Related issue :

@enolfc enolfc requested a review from gwarf March 17, 2023 12:42
gwarf
gwarf approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
As a side remark, I feel it may be cleaner to not use real names/endpoints in the tests.

@enolfc enolfc merged commit 5775ad4 into EGI-Federation:master Mar 20, 2023
@enolfc enolfc deleted the multiple-endpoints branch March 20, 2023 06:47
@enolfc enolfc mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwarf gwarf gwarf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@enolfc @gwarf