Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative links in adhoc tutorials #600

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Fix relative links in adhoc tutorials #600

merged 3 commits into from
Jun 2, 2023

Conversation

sebastian-luna-valero
Copy link
Member

Summary

Strange that this wasn't picked up in #598


Related issue :

@gwarf gwarf added the safe for preview Pull request vetted as safe for preview label Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/600

@gwarf
Copy link
Member

gwarf commented Jun 1, 2023

Strange that this wasn't picked up in #598

It's likely due to this setting:
https://github.com/EGI-Federation/documentation/blob/main/.github/workflows/check-links.yml#L22-L26

Would probably be good to update it, as it's seems a quite idea to ensure that no changes on organisations are not breaking links.
That said we should also be sure that all false positives are excluded (meaning as due to this we may still miss some broken links)

@gwarf
Copy link
Member

gwarf commented Jun 1, 2023

If you want/have time we could use this PR to run this check on all files, and fix other issues.
Otherwise it's for later...

@sebastian-luna-valero sebastian-luna-valero changed the title Fix relative links in adhoc tutorial to create first VM Fix relative links in adhoc tutorials Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/600

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gwarf
Copy link
Member

gwarf commented Jun 1, 2023

@sebastian-luna-valero can you remove the link to https://wiki-igi.cnaf.infn.it/twiki/bin/view/CREAM/UserGuideEMI3 ? We still have another reference, and we will later just purge this.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/600

@enolfc
Copy link
Contributor

enolfc commented Jun 2, 2023

If you want/have time we could use this PR to run this check on all files, and fix other issues. Otherwise it's for later...

I would merge now so we have this fixed. Then open a new one with fixing other broken links

@gwarf gwarf merged commit f6d56be into main Jun 2, 2023
16 checks passed
@gwarf gwarf deleted the fix-links branch June 2, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe for preview Pull request vetted as safe for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants