New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora COPR repo to wiki #20

Closed
gombosg opened this Issue Dec 6, 2018 · 25 comments

Comments

Projects
None yet
7 participants
@gombosg
Copy link

gombosg commented Dec 6, 2018

Hi, I created this COPR (user) repo for the package:
https://copr.fedorainfracloud.org/coprs/gombosg/pulseaudio-modules-bt-aptx/

I repackaged the original Fedora Pulseaudio source with your patches. It works for me™, hopefully people can test it this way. Please add it to the wiki.

@EHfive

This comment has been minimized.

Copy link
Owner

EHfive commented Dec 6, 2018

@EHfive

This comment has been minimized.

Copy link
Owner

EHfive commented Dec 6, 2018

@EHfive EHfive closed this Dec 6, 2018

@gombosg

This comment has been minimized.

Copy link
Author

gombosg commented Dec 6, 2018

Thanks, I'll update to patch 3 & integrate libldac.

@gombosg

This comment has been minimized.

Copy link
Author

gombosg commented Dec 18, 2018

@inffy

This comment has been minimized.

Copy link

inffy commented Jan 22, 2019

@gombosg seems this copr repo has been removed. It worked fine this morning when I installed. Did something happen?

@gombosg

This comment has been minimized.

Copy link
Author

gombosg commented Jan 22, 2019

Yes, I just got mail today:

Hi,

Unfortunately, I had to delete your gombosg/pulseaudio-modules-bt-aptx
copr. It contains packages which cannot be distributed by Fedora due to
legal concerns.

Please remember that legally encumbered items may not be included in
either Fedora or Coprs.

Thanks,

Tom Callaway
Fedora Legal

I was suspecting that this might happen one day. I love Fedora but f*ck them for censoring COPR repos.

What now...? Maybe submitting the package to RPMFusion? (Does anyone know an RPMFusion packager to get this sponsored...) Waiting till it gets merged into PulseAudio?

Sources are here:
https://pagure.io/libldac
https://pagure.io/pulseaudio-module-bluetooth-aptx

@inffy

This comment has been minimized.

Copy link

inffy commented Jan 23, 2019

I guess RPMFusion would be the best bet, or some other repo. I have no clue how to submit packages/get packages to rpmfusion though or if there would be other "public" repos that would take it.

Shame really, just got my F29 set up the way i like it with this, never could get this to work with my manjaro install.

@inffy

This comment has been minimized.

Copy link

inffy commented Jan 23, 2019

@gombosg i found this from rpmfusion: https://rpmfusion.org/Contributors#Submitting_a_new_package

or you can ask in #rpmfusion channel in irc.freenode.net

@gombosg

This comment has been minimized.

Copy link
Author

gombosg commented Jan 23, 2019

Thanks!
In the meantime, here's the F29 RPM file.
pa-bt-aptx.zip

@gombosg

This comment has been minimized.

Copy link
Author

gombosg commented Jan 24, 2019

@EHfive What is the status for merging into upstream? If not expected, I'll post to RPMFusion since getting kicked out from the Fedora COPR repo.

@inffy

This comment has been minimized.

Copy link

inffy commented Jan 24, 2019

@gombosg thanks for the rpm, but it can't be installed because no libldac can be found (as its not in any repo)

@EHfive

This comment has been minimized.

Copy link
Owner

EHfive commented Jan 25, 2019

@EHfive What is the status for merging into upstream? If not expected, I'll post to RPMFusion since getting kicked out from the Fedora COPR repo.

Currently it won't be merged.

@gombosg

This comment has been minimized.

Copy link
Author

gombosg commented Jan 25, 2019

@inffy I added it to my comment above... seems that going to RPMFusion is the way currently. I'll look into it in the upcoming days.

@mumrau

This comment has been minimized.

Copy link

mumrau commented Feb 7, 2019

Maybe we could re-open the issue until a user-friendly (i.e repository) solution is found and added into the wiki? So people can subscribe to it and get a decent overview on the RPM situation.

@inffy

This comment has been minimized.

Copy link

inffy commented Feb 7, 2019

No need. It's not hard to install two rpm files.

@mumrau

This comment has been minimized.

Copy link

mumrau commented Feb 7, 2019

But they won't be kept up to date eventually.
Plus for some users, yes it is, you even need to search the issue, the doc doesn't state it (probably because it isn't the intended way to serve the packages in the (near) future).

@gombosg

This comment has been minimized.

Copy link
Author

gombosg commented Feb 7, 2019

Hi guys, I have submitted libldac to Fedora and the aptx module to RPMFusion. They will find their home there... review just takes time. :)

In the meantime you can indeed install the RPMs directly.

@davidlt

This comment has been minimized.

Copy link

davidlt commented Feb 11, 2019

Just discovered this package a day ago. I am happy to help with any SPEC/RPM related questions/issues. Looks like libldac is stuck on FE-Legal, but comments are positive here.

There is a comment regarding "fdk-aac" package, which basically means that this targets nonfree repo in RPMFusion.

Nice work!

@gombosg

This comment has been minimized.

Copy link
Author

gombosg commented Feb 11, 2019

@davidlt Thanks, the package would be approved soon, they just need to lift the FE-LEGAL bug.
Are you a Fedora packager yourself? I could use some guidance getting into reviewing packages. :)

@davidlt

This comment has been minimized.

Copy link

davidlt commented Feb 12, 2019

@gombosg I am not a packager, but I maintain RISC-V 64-bit Fedora port thus I can help with technical bits.

Btw, people are writing about the project and your work:

@Sesivany

This comment has been minimized.

Copy link

Sesivany commented Feb 12, 2019

Hi guys, I have submitted libldac to Fedora and the aptx module to RPMFusion. They will find their home there... review just takes time. :)

In the meantime you can indeed install the RPMs directly.

Can't it be package the way that it could get into Fedora and at least enable LDAC there and then it could be extended by some package from RPMFusion with support for AptX, AptX-HD etc.? It's a pity to rely on RPMFusion even for LDAC if it's accepted in Fedora.

@gombosg

This comment has been minimized.

Copy link
Author

gombosg commented Feb 12, 2019

@Sesivany Would be great but according to the Fedora legal & packaging guidelines:

  • Patent-encumbered stuff is not allowed (ffmpeg)
  • All build dependencies must be within the Fedora repos

I'm just the packager, @EHfive can tell whether it's possible to create or build the package without ffmpeg and AAC present, with only LDAC. (I guess that version won't have aptX and AAC support even if the codec packages are installed.)

It's not impossible but not sure either. Essentially it wouldn't be a new package then, just a patch to be applied against the Fedora version of PA and a PR could be submitted here.

In RPMFusion we already started the discussion and it will simply be a pulseaudio-module-bluetooth-nonfree package replacing the original, that would contain all codecs.

Edit: to sum up, if libldac gets into the Fedora repos and it's possible to convert the project into a patch with LDAC only, then I will submit a PR to the Fedora version of PA.

@EHfive

This comment has been minimized.

Copy link
Owner

EHfive commented Feb 13, 2019

I'm just the packager, @EHfive can tell whether it's possible to create or build the package without ffmpeg and AAC present, with only LDAC. (I guess that version won't have aptX and AAC support even if the codec packages are installed.)

Right. In the next release, I would probably make FDK-AAC/ffmpeg/LDAC be optional at building stage.

@Sesivany

This comment has been minimized.

Copy link

Sesivany commented Feb 13, 2019

That would really help because then we could have it at least with LDAC support in Fedora/RHEL (and other patent-concerned distributions) by default although some claim there is also a problem with LGPL 2.1->Apache License compatibility. But this project has had 3 contributors so far, so it shouldn't be such a problem to grant an exception if necessary.

@lukehutch

This comment has been minimized.

Copy link

lukehutch commented Feb 14, 2019

The soname version number for fdk-aac in rpmfusion is 2, not 1:

[root@localhost ~]# rpm -Uhv /tmp/libldacbt-1.1-1.fc29.x86_64.rpm /tmp/pulseaudio-module-bluetooth-aptx-12.2-1.fc29.x86_64.rpm 
error: Failed dependencies:
	libfdk-aac.so.1()(64bit) is needed by pulseaudio-module-bluetooth-aptx-12.2-1.fc29.x86_64
[root@localhost ~]# rpm -ql fdk-aac | grep libfdk-aac
/usr/lib64/libfdk-aac.so.2
/usr/lib64/libfdk-aac.so.2.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment