Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to filter on *different* metrics during scoring #130

Closed
lucventurini opened this issue Oct 3, 2018 · 2 comments
Closed

Allow to filter on *different* metrics during scoring #130

lucventurini opened this issue Oct 3, 2018 · 2 comments
Assignees
Projects
Milestone

Comments

@lucventurini
Copy link
Collaborator

lucventurini commented Oct 3, 2018

Currently, when evaluating a metric for scoring, it is possible to specify conditions that would make Mikado assign to it a score of 0. For example, if we are considering the metric non_verified_introns_num, we cannot explicitly say that this metric should be ignored when the transcript is monoexonic.

A solution could be allowing expressions of the form:

non_verified_introns_num:
  rescaling: max
  multiplier: -10
  filter:
    operator: gt
    value: 1
    metric: exons_num

This would allow to filter based on different metrics than the one examined.

lucventurini added a commit that referenced this issue Oct 3, 2018
…dered correctly and the configuration file should be parsed and checked appropriately
@lucventurini
Copy link
Collaborator Author

An issue has emerged: currently, when a transcript is excluded from the scoring for a metric because it runs afoul of the filter, its metric value is still being considered for calculating the boundaries of the scoring.

So for example if e.g. the scoring is on "maximum length of the 3'UTR, with a filter after 2500bps", if a transcript with a UTR of 3000bps is present in the locus no transcript will get the full scoring, because the maximum is 3000, not the longest UTR which does not run afoul of the filter.

This requires to rearrange the order of the operations within the scoring function.

lucventurini added a commit that referenced this issue Oct 3, 2018
@lucventurini lucventurini added this to the 1.3 milestone Oct 5, 2018
@lucventurini
Copy link
Collaborator Author

Fixed and tested, closing for now.

@lucventurini lucventurini added this to Closed in Version 2 Oct 15, 2020
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
…etric should be considered correctly and the configuration file should be parsed and checked appropriately
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
…sue of targeting including excluding objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants