-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canonicalize stream epochs #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
977d270
to
d45a2b6
Compare
b4f6f39
to
842f7d8
Compare
7c04374
to
853ce58
Compare
Canonicalization now works with epochs which are defined as overlapping epochs. Note that this is a workaround. Correctly defining epochs (i.e. as non-overlapping epochs) wouldn't have required this fix. Besides, this commit includes removing the `merge` query filter parameter from eidaws-stationlite, since merging channel epochs disagrees with the canonicalization approach implemented. Note that this change implies also that fdsnws-station level=channel|response stream epochs are returned mostly as originally defined (i.e. with the canonicalization correction applied).
Instead, make this the default option.
Optionally keep them sorted.
Increase cache locality.
- Provide new CLI arguments `--history-json-load` and `--history-include-supplementary-epochs`. - Rename `--dump-history-json` to `--history-json-dump`.
This was referenced May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #10 and #11.
Features and Changes:
eidaws-stationlite
returns canonicalized stream epochs which implies that stream epochs are not merged, anymore. This partly reverts Return real epochs forservice=station
#10eida-crawl-fdsnws-station
drops the--original-epochs
CLI parameter which now is the defaulteida-crawl-fdsnws-station
now provides history based crawlingeida-crawl-fdsnws-station