Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified imports and refactored #14

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

andreped
Copy link
Collaborator

@andreped andreped commented Aug 5, 2022

As discussed in #13 (comment), I have simplified the imports, such that it works as expected. Simply use torchstain.MacenkoNormalizer(backend) as before, but works seemlessly with all backends.

As I believe this is now ready to be released, I also did some refactoring in the README and whatnot. I made a suggestion to edit the description of the tool in the README. You can edit as you please.

I set to merge with the backends branch. You can merge with main after if you approve of edits.

Changes:

  • Simplied imports
  • Renamed base subpackage to core
  • Minor refactoring in README and code
  • In 2022, I prefer pip over pip3

@andreped andreped added the enhancement New feature or request label Aug 5, 2022
@andreped andreped self-assigned this Aug 5, 2022
@carloalbertobarbano
Copy link
Member

Thanks. I had some work started on this already, I will see tomorrow about merging them 👍

@andreped
Copy link
Collaborator Author

andreped commented Aug 5, 2022

Thanks. I had some work started on this already, I will see tomorrow about merging them 👍

After taking a nap, I got an idea of how to solve the problem, and it seems like the nap worked :p Quite easy in the end. Just me being silly

@carloalbertobarbano carloalbertobarbano merged commit 2e5d8cc into EIDOSLAB:backends Aug 8, 2022
@carloalbertobarbano
Copy link
Member

Merged into the backends branch. I kept the "core" backage named to "base" as it is more appropriate for providing base classes.
I also moved the numpy implementation to its own backend package, for coherence with the rest of the codebase

@andreped
Copy link
Collaborator Author

andreped commented Aug 8, 2022

I also moved the numpy implementation to its own backend package, for coherence with the rest of the codebase

Good idea. I was thinking about doing the same, but I was lazy :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants