Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DuckDuckGo dark theme is unreadable #24

Closed
thinkh opened this issue May 2, 2023 · 6 comments
Closed

DuckDuckGo dark theme is unreadable #24

thinkh opened this issue May 2, 2023 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@thinkh
Copy link

thinkh commented May 2, 2023

Describe the bug

When using the DuckDuckGo dark theme some parts of the copilot sidebar are unreadable.

To Reproduce
Steps to reproduce the behavior:

  1. Go to DuckDuckGo
  2. Switch to dark theme in settings
  3. Search for something that is available in the local graph
  4. See result

Expected behavior

The colors should have a better contrast in the dark theme.

Screenshots
If applicable, add screenshots to help explain your problem.

Default white theme

grafik

Switch to dark theme

grafik

Dark theme

grafik

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Firefox
  • Version: 112
@EINDEX EINDEX added bug Something isn't working good first issue Good for newcomers labels May 3, 2023
@howarddo2208
Copy link
Contributor

I suspect the tailwind doesn't recognize theme change, but upon trying to fiddle with the code, I ran to an issue with the build script. Do you know how to resolve this @EINDEX ?

> logseq-copliot@1.6.0 build
> node build.mjs

/Users/tanhopdo/Developments/opensource/logseq-copilot/src/manifest.json.cjs:28
    version: process.env.VERSION.replace('v', ''),
                                 ^

TypeError: Cannot read properties of undefined (reading 'replace')
    at build (/Users/tanhopdo/Developments/opensource/logseq-copilot/src/manifest.json.cjs:28:34)
    at build (file:///Users/tanhopdo/Developments/opensource/logseq-copilot/build.mjs:96:20)

Node.js v18.16.0

@EINDEX
Copy link
Owner

EINDEX commented May 6, 2023

Sorry those days were busy with work, you have to set env var before build.

@howarddo2208

export VERSION=v0.0.0

EINDEX added a commit that referenced this issue May 6, 2023
Signed-off-by: EINDEX <snowstarlbk@gmail.com>
@EINDEX
Copy link
Owner

EINDEX commented May 6, 2023

I force the font color for dark and light modes, which will suit for system's default theme.
If change theme at search engine, may can not using the correct theme.

Will keep this open until copilot can support theme by sites.

@howarddo2208
Copy link
Contributor

Yeah, it doesn't update based on the site. But turns out the problem is actually from the body style, other search sites update the body {color} when changing the theme and the extension inherit it, but it is not the case for duckduckgo

@howarddo2208
Copy link
Contributor

now you fixed the issue by hard-code the text color, but then the light theme on all sites is unreadable @EINDEX.
image
Please consider my PR #26 . Btw, I tested the tailwind, it never switches to dark tho, so I think all the dark: styles are not used.

EINDEX added a commit that referenced this issue May 7, 2023
This reverts commit bab916c.

Signed-off-by: EINDEX <snowstarlbk@gmail.com>
@EINDEX
Copy link
Owner

EINDEX commented May 7, 2023

@howarddo2208 your solutions are awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants