Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12, versioneer build failure #183

Open
scop opened this issue Jan 7, 2023 · 6 comments
Open

Python 3.12, versioneer build failure #183

scop opened this issue Jan 7, 2023 · 6 comments

Comments

@scop
Copy link

scop commented Jan 7, 2023

versioneer.py attempts to use configparser.SafeConfigParser which has been deprecated for a long time, and now removed in Python 3.12, causing build to fail.

Upgrading versioneer to a newer version would seem likely to fix this: python-versioneer/python-versioneer#200

@Ryanmt2
Copy link

Ryanmt2 commented Feb 7, 2024

Is this library still maintained and open for PRs?

@DustyArmstrong
Copy link

DustyArmstrong commented Feb 8, 2024

It appears the repository is likely not being maintained. If I am understanding correctly then the fix appears it may be as simple as changing these lines in versioneer.py:

342 parser = configparser.SafeConfigParser() to parser = configparser.ConfigParser()

344 parser.readfp(f) to parser.read_file(f)

I think people would be happy to contribute to its maintenance if able.

@EJEP
Copy link
Owner

EJEP commented Feb 8, 2024

Hi, I haven't been able to do much with the repo.o er the last few years. I'll take a look at the pull request that updates versioneer this weekend.

@DustyArmstrong
Copy link

Thanks, appreciate it and your efforts to create the project. I use Datapoint every day (Home Assistant integration) so would be thrilled to keep using it if possible. I am a fair weather coder so can't say for sure but I hope the PR resolves.

@EJEP
Copy link
Owner

EJEP commented Feb 9, 2024

This should be fixed in version 0.9.9 - I could install it from pypi in a python 3.12 environment on my machine.

I bumped the entire versioneer package, but ended up disabling it. The packaging logic here is really out of date now, so I'll see if I can get it into a better state if it looks like this library will be usable with the new API

@pssc
Copy link

pssc commented Feb 17, 2024

Mention the HA pull as we cant comment on it due to being locked to collaborators :-(. This should allow this to be reintegrated into HA. home-assistant/core#108163

        Yup, sadly not a lot I can do for MetOffice at the moment if the datapoint library isn't going to be compatible 😭

Originally posted by @MrHarcombe in home-assistant/core#108163 (comment)

And a link to HA issue home-assistant/core#109301

and re-enabled by home-assistant/core#110206 maybe in HA 2024.2.2 Thanks @DustyArmstrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants