New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump datapoint to 0.9.9 + re-enable Met Office Integration #110206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @MrHarcombe, @avee87, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Let’s just bump the required version of datapoint to 0.9.9 in manifest and reenable the integration. |
I did that initially on my local fork, but the variables have changed so it will fail if it stays as-is. |
I meant doing that in addition to your changes in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7a6910b
to
e813f94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
- A link to the release notes of this package version, and all versions in between.
- A link to the changelog of this package.
- A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.
Thanks already! 👍
Need to fix the CI for 3.12. Apologies for the back and forth with this, my initial intent with the PR was just to add a small fix to 2 files to assist whoever re-enabled the integration (that just happened to be me so I'm still picking things up). EDIT: Modified the |
796febe
to
aa12fae
Compare
Not sure why this keeps hitting problems but I've re-run Ruff. |
Update helpers.py to reflect changes made to variable in https://github.com/EJEP/datapoint-python/blob/master/CHANGELOG.md
Update sensor.py to reflect changes made to variables as mentioned in https://github.com/EJEP/datapoint-python/blob/master/CHANGELOG.md
Update __init__.py to remove reference to Python 3.12 requirement.
Update helpers.py to remove reference to <3.12
Updated data.py to remove references to Python < 3.12 though having the original lines did not actually impact functionality
Update for v 0.9.9
Remove disabled tag
Bump datapoint dependency following fix EJEP/datapoint-python#183
Generated with requirements script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DustyArmstrong 👍
Breaking change
Proposed change
The change is to bump the datapoint dependency and update two files that still use
site.id
and bring them in-line withdatapoint-python
0.9.9 to allow functionality to continue if the integration is re-enabled on a temporary basis until the new API wrapper can be developed.Datapoint CHANGELOG (incl. all prior): https://github.com/EJEP/datapoint-python/blob/migrate_to_datahub/CHANGELOG.md
Datapoint PRIMARY DIFF: EJEP/datapoint-python@c07b274
Further files have been changed and can be seen here: https://github.com/EJEP/datapoint-python/commits/master/
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: