Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy id and api key #170

Merged
merged 7 commits into from
Oct 10, 2020
Merged

Tidy id and api key #170

merged 7 commits into from
Oct 10, 2020

Conversation

EJEP
Copy link
Owner

@EJEP EJEP commented Oct 10, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #170 into master will decrease coverage by 0.60%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   34.56%   33.95%   -0.61%     
==========================================
  Files          11       11              
  Lines         486      480       -6     
  Branches       92       92              
==========================================
- Hits          168      163       -5     
+ Misses        313      312       -1     
  Partials        5        5              
Flag Coverage Δ
#integration 33.95% <55.55%> (-0.61%) ⬇️
#unit 33.95% <55.55%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datapoint/Manager.py 18.70% <0.00%> (ø)
datapoint/regions/RegionManager.py 44.73% <0.00%> (ø)
datapoint/Element.py 37.50% <50.00%> (ø)
datapoint/Site.py 18.75% <50.00%> (+1.10%) ⬆️
datapoint/Day.py 31.25% <100.00%> (-4.05%) ⬇️
datapoint/Forecast.py 75.00% <100.00%> (-0.48%) ⬇️
datapoint/Observation.py 100.00% <100.00%> (ø)
datapoint/Timestep.py 70.00% <100.00%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0620481...fa58dbd. Read the comment docs.

@EJEP
Copy link
Owner Author

EJEP commented Oct 10, 2020

Resolves #164 and #165

@EJEP EJEP merged commit 305446f into master Oct 10, 2020
@EJEP EJEP deleted the tidy_id_and_api_key branch October 10, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove api key from Timestep Use something other than id in Element
1 participant