Add option to change system language #99
Conversation
src/emu/common/src/language.cpp
Outdated
| #include <common/language.h> | ||
| #include <map> | ||
|
|
||
| static std::map<int, std::string> lang_map { |
There was a problem hiding this comment.
Did you write a python script for this :p. I think real language name would be more friendly for userend
There was a problem hiding this comment.
Nope, just some multi-cursor editing in VSCode. Do you know where I can find official mapping from code to displaied language name?
There was a problem hiding this comment.
I do find some of them here, some languages are missing though
There was a problem hiding this comment.
just removing ELang prefix in enum names looks fine
There was a problem hiding this comment.
Yeah, that should be viable
| @@ -495,6 +497,17 @@ namespace eka2l1 { | |||
| ImGui::Separator(); | |||
| } | |||
|
|
|||
| struct SLocaleLanguage { | |||
There was a problem hiding this comment.
Can you define this struct somewhere like in epoc/utils? We so can share this struct without having to define it multiple times.
There was a problem hiding this comment.
Moved to epoc/utils/locale.h, and I copied definition of enum TLanguage to there too since including e32lang.h causes compiling errors, is that OK?
|
|
||
| namespace eka2l1::epoc { | ||
|
|
||
| enum TLanguage { |
There was a problem hiding this comment.
Please format this file to not uses tab, but rather space with 4-spaces identation
Also rename SLocaleLanguage to our struct naming convention (under_score)
There was a problem hiding this comment.
I have fixed the tab in previous commits, the naming is changed just now.
|
Thanks! |
TRR95
added
Added / Resolved / Fixed
No description provided.