Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging/Building of Malis loss #3

Open
mdraw opened this issue May 18, 2017 · 0 comments
Open

Packaging/Building of Malis loss #3

mdraw opened this issue May 18, 2017 · 0 comments

Comments

@mdraw
Copy link
Member

mdraw commented May 18, 2017

Compilation of the native extension required for the malis loss function is currently disabled in setup.py for two reasons:

  • Enabling it would force us to make the elektronn2 package platform-specific and we would have to jump through hoops to get installable wheels on all supported platforms every release. Without malis, elektronn2 is pure-python (meaning we can publish universal wheels).
  • There is a boost-related issue with building on some CentOS 6 machines.

My idea is to split the malis binary module out to a separate package that is an (optional) requirement of ELEKTRONN2 so we can keep a clean pure-python codebase in the main package while offloading the boost- and c++-dependent malis to a separate package, for which we can do the time-consuming build and release of platform-wheels once and hopefully won't need to re-release it for a long time.
Any thoughts on this?

(Note: If you want to use malis in ELEKTRONN2, you currently have to change this line to malis = True and install from source.)

@mdraw mdraw self-assigned this May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant